Trade skills don't benefit specific classes per se. Their purpose is to make things which you can use or you can sell to other players. In progression days all the skills had some value but it seems to me, IIRC, that jewelcraft had the best potential for making plat since player-made jewelry, like the HP/mana rings, earrings and necklaces, were in great demand. Smithing and Tailoring had their value too since everybody needs gear to wear. It was always clear that jewelcraft was an expensive skill to raise since skillups required expensive components that were not available from vendors, like diamonds and blue diamonds. Alchemy was useful in those days too but that's a trade that only shamans can learn, as with poison-making for rogues. I do remember that I made a LOT of pp way back when with my enchanter and her jewelcraft skill.
____________________________
Sippin 115 DRU **** Firiona Vie ****Agnarr
FV: 115 WAR ENC CLE MAG WIZ SHD SHM Master Alchemist ROG Master Tinkerer & Poison-Maker
Master Artisan (300+) * Baker * Brewer * Fletcher * Jeweler * Potter * Researcher * Smith * Tailor
Agnarr: 65 DRU ENC SHD MAG CLE ROG WIZ BRD WAR